lokeshj1703 commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2018367574
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -431,7 +433,7 @@ public void testRollbackForMultiwriter() throws Exception {
public void testRollbackWhenReplaceCommitIsPresent() throws Exception {
// insert data
- HoodieWriteConfig writeConfig =
getConfigBuilder().withAutoCommit(false).build();
+ HoodieWriteConfig writeConfig =
getConfigBuilder().withAutoCommit(false).withEmbeddedTimelineServerEnabled(false).build();
Review Comment:
I have removed the changes based on comment -
https://github.com/apache/hudi/pull/13007#discussion_r2017964552
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -268,8 +269,8 @@ public void testRollbackScale() throws Exception {
.addCommit("003")
.withBaseFilesInPartition(p3, fileLengths);
- HoodieTable table = this.getHoodieTable(metaClient,
getConfigBuilder().withRollbackUsingMarkers(false).build());
- HoodieInstant needRollBackInstant =
INSTANT_GENERATOR.createNewInstant(HoodieInstant.State.COMPLETED,
HoodieTimeline.COMMIT_ACTION, "003");
+ HoodieTable table = this.getHoodieTable(metaClient,
getConfigBuilder().withRollbackUsingMarkers(false).withEmbeddedTimelineServerEnabled(false).build());
+ HoodieInstant needRollBackInstant = new
HoodieInstant(HoodieInstant.State.INFLIGHT, HoodieTimeline.COMMIT_ACTION,
"003", InstantComparatorV1.REQUESTED_TIME_BASED_COMPARATOR);
Review Comment:
I have removed the changes based on comment -
https://github.com/apache/hudi/pull/13007#discussion_r2017964552
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -106,7 +107,7 @@ public void
testCopyOnWriteRollbackActionExecutorForFileListingAsGenerateFile()
.withBaseFilesInPartition(p1, "id21").getLeft()
.withBaseFilesInPartition(p2, "id22").getLeft();
- HoodieWriteConfig writeConfig =
getConfigBuilder().withRollbackUsingMarkers(false).build();
+ HoodieWriteConfig writeConfig =
getConfigBuilder().withRollbackUsingMarkers(false).withEmbeddedTimelineServerEnabled(false).build();
Review Comment:
Yeah I agree, it should not be required for log file marker. Removing the
changes for this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
