n3nash commented on a change in pull request #2197:
URL: https://github.com/apache/hudi/pull/2197#discussion_r511706427
##########
File path:
hudi-integ-test/src/main/java/org/apache/hudi/integ/testsuite/generator/DeltaGenerator.java
##########
@@ -77,6 +82,16 @@ public DeltaGenerator(DeltaConfig deltaOutputConfig,
JavaSparkContext jsc, Spark
}
public JavaRDD<DeltaWriteStats> writeRecords(JavaRDD<GenericRecord> records)
{
+ if (deltaOutputConfig.shouldDeleteOldInputData() && batchId > 1) {
+ Path oldInputDir = new Path(deltaOutputConfig.getDeltaBasePath(),
Integer.toString(batchId - 1));
Review comment:
This may not work in case the last batches were rolled back. Can you
take a look at RollbackNode and see what will be the implication ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
