yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2019140959
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackActionExecutor.java:
##########
@@ -123,6 +124,11 @@ private HoodieRollbackMetadata runRollback(HoodieTable<T,
I, K, O> table, Hoodie
// Finally, remove the markers post rollback.
WriteMarkersFactory.get(config.getMarkersType(), table,
instantToRollback.requestedTime())
.quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism());
+ if
(table.getMetaClient().getTableConfig().getTableVersion().lesserThan(HoodieTableVersion.EIGHT))
{
+ // For MOR table rollbacks, rollback command blocks might generate
markers under rollback instant. So, lets clean up the markers if any.
+ WriteMarkersFactory.get(config.getMarkersType(), table,
rollbackInstant.requestedTime())
+ .quietDeleteMarkerDir(context, config.getMarkersDeleteParallelism());
Review Comment:
I see, the instant time is different; that's how I got confused.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
