jonvex commented on code in PR #12340:
URL: https://github.com/apache/hudi/pull/12340#discussion_r2023146729
##########
hudi-client/hudi-spark-client/src/main/scala/org/apache/hudi/SparkFileFormatInternalRowReaderContext.scala:
##########
@@ -165,7 +165,7 @@ class
SparkFileFormatInternalRowReaderContext(parquetFileReader: SparkParquetRea
HoodieAvroUtils.removeFields(skeletonRequiredSchema, rowIndexColumn))
//If we need to do position based merging with log files we will leave
the row index column at the end
- val dataProjection = if (getHasLogFiles &&
getShouldMergeUseRecordPosition) {
+ val dataProjection = if (getShouldMergeUseRecordPosition) {
Review Comment:
Part of this pr is to cleanup/clarify what things mean.
shouldMergeUseRecordPosition has been clarified to be specific to mor merging,
so log files must be present for this to be true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
