TheR1sing3un commented on code in PR #13070:
URL: https://github.com/apache/hudi/pull/13070#discussion_r2024170453
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieReaderConfig.java:
##########
@@ -89,4 +91,15 @@ public class HoodieReaderConfig extends HoodieConfig {
"hoodie.write.record.merge.custom.implementation.classes";
public static final String
RECORD_MERGE_IMPL_CLASSES_DEPRECATED_WRITE_CONFIG_KEY =
"hoodie.datasource.write.record.merger.impls";
+
+ public static final ConfigProperty<Double>
LOG_FILE_TO_PARQUET_FORMAT_SIZE_ESTIMATION_FRACTION = ConfigProperty
+ .key("hoodie.logfile.to.parquet.format.size.estimation.fraction")
Review Comment:
> Why not just use `config.getLogFileToParquetCompressionRatio()`?
`HoodieStorageConfig#LOGFILE_TO_PARQUET_COMPRESSION_RATIO_FRACTION` belongs
to the group `WRITE_CLIENT`.
<img width="543" alt="image"
src="https://github.com/user-attachments/assets/1342b79a-2094-4f9d-9dc7-1fe94687a99a";
/>
Is it unreasonable for us to use a write client-related parameter when
reading? By the way, this also raises another issue, many of the parameters
that we use should be common to both read and write, but we put them in write
config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
