the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2025819190
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/HoodieTableFileSystemView.java:
##########
@@ -56,8 +56,6 @@ public class HoodieTableFileSystemView extends
IncrementalTimelineSyncFileSystem
private static final Logger LOG =
LoggerFactory.getLogger(HoodieTableFileSystemView.class);
- //TODO: [HUDI-6249] change the maps below to implement ConcurrentMap
Review Comment:
This ticket is actually the same issue I ran into. With the read/write lock
we can also consider switching from ConcurrentHashMap to HashMap for the maps
used in this class.
cc @jonvex
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -396,10 +405,7 @@ private void ensurePartitionsLoadedCorrectly(List<String>
partitionList) {
LOG.debug("Time taken to list partitions {} ={}", partitionSet,
(endLsTs - beginLsTs));
pathInfoMap.forEach((partitionPair, statuses) -> {
String relativePartitionStr = partitionPair.getLeft();
- List<HoodieFileGroup> groups =
addFilesToView(relativePartitionStr, statuses);
- if (groups.isEmpty()) {
- storePartitionView(relativePartitionStr,
Collections.emptyList());
- }
Review Comment:
This code was repeated so I moved it into the `addFilesToView` method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
