the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2027011867
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -701,9 +704,9 @@ public final Stream<Pair<String, CompactionOperation>>
getPendingLogCompactionOp
@Override
public final Stream<HoodieBaseFile> getLatestBaseFiles(String partitionStr) {
try {
- readLock.lock();
String partitionPath = formatPartitionKey(partitionStr);
ensurePartitionLoadedCorrectly(partitionPath);
+ readLock.lock();
Review Comment:
I think we should unify the two methods where
`ensurePartitionLoadedCorrectly` calls `ensurePartitionsLoadedCorrectly` with a
singleton list to reduce repeated code.
Do we really need this extra data structure for tracking `addedPartitions`
if there is also a call to `isPartitionAvailableInStore` to check whether the
partition is already loaded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
