lokeshj1703 commented on code in PR #13079:
URL: https://github.com/apache/hudi/pull/13079#discussion_r2027493226
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordMerger.java:
##########
@@ -186,23 +187,28 @@ default String[] getMandatoryFieldsForMerging(Schema
dataSchema, HoodieTableConf
*/
String getMergingStrategy();
- static String getRecordMergeStrategyId(RecordMergeMode mergeMode,
- String payloadClassName,
- String recordMergeStrategyId) {
+ static String getRecordMergeStrategyId(RecordMergeMode mergeMode, String
payloadClassName,
+ String recordMergeStrategyId,
HoodieTableVersion tableVersion) {
switch (mergeMode) {
case COMMIT_TIME_ORDERING:
return COMMIT_TIME_BASED_MERGE_STRATEGY_UUID;
case EVENT_TIME_ORDERING:
return EVENT_TIME_BASED_MERGE_STRATEGY_UUID;
case CUSTOM:
default:
+ String stategyId = null;
Review Comment:
I have addressed the review comment so that the logic becomes more clear.
Kept it the way it is described in
https://github.com/apache/hudi/pull/13079#discussion_r2027438488.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
