danny0405 commented on code in PR #13078:
URL: https://github.com/apache/hudi/pull/13078#discussion_r2028125804
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/compact/HoodieFlinkMergeOnReadTableCompactor.java:
##########
@@ -60,4 +79,19 @@ public void preCompact(
public void maybePersist(HoodieData<WriteStatus> writeStatus,
HoodieEngineContext context, HoodieWriteConfig config, String instantTime) {
// No OP
}
+
+ @Override
+ public List<WriteStatus> compact(HoodieCompactionHandler compactionHandler,
+ HoodieTableMetaClient metaClient,
+ HoodieWriteConfig writeConfig,
+ CompactionOperation operation,
+ String instantTime,
+ Option<EngineBroadcastManager>
broadcastManagerOpt) throws IOException {
+ Configuration conf =
metaClient.getStorage().getConf().unwrapAs(Configuration.class);
+ FlinkRowDataReaderContext readerContext = new FlinkRowDataReaderContext(
Review Comment:
Looks like there is no need to store Flink conf in
`FlinkRowDataReaderContext`, the `InternalSchemaManager` needs the Flink conf
to do 2 things:
1. decide if the schema evolution is enabled: we can move this check into
`HoodieWriteConfig.isSchemaEvolutionEnabled`;
2. generates Hadoop conf from it, but the hadoop conf is already in
`FlinkRowDataReaderContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
