TheR1sing3un commented on code in PR #13066:
URL: https://github.com/apache/hudi/pull/13066#discussion_r2026123504
##########
hudi-spark-datasource/hudi-spark-common/src/main/java/org/apache/hudi/internal/DataSourceInternalWriterHelper.java:
##########
@@ -85,14 +97,49 @@ public void commit(List<WriteStatus> writeStatuses) {
try {
List<HoodieWriteStat> writeStatList =
writeStatuses.stream().map(WriteStatus::getStat).collect(Collectors.toList());
writeClient.commitStats(instantTime, writeStatList,
Option.of(extraMetadata),
- CommitUtils.getCommitActionType(operationType,
metaClient.getTableType()));
+ CommitUtils.getCommitActionType(operationType,
metaClient.getTableType()), getReplacedFileIds(writeStatuses), Option.empty());
} catch (Exception ioe) {
throw new HoodieException(ioe.getMessage(), ioe);
} finally {
writeClient.close();
}
}
+ private Map<String, List<String>> getReplacedFileIds(List<WriteStatus>
writeStatuses) {
Review Comment:
> Can we move the writes and commits inside the executors?
Of course we can, then we don't need `DataSourceInternalWriterHelper ` to
perform writes and commits, all writes and commits are consolidated inside
executor, and I'll make changes to follow that logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
