the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2025892738
##########
hudi-common/src/main/java/org/apache/hudi/common/table/view/AbstractTableFileSystemView.java:
##########
@@ -701,9 +704,9 @@ public final Stream<Pair<String, CompactionOperation>>
getPendingLogCompactionOp
@Override
public final Stream<HoodieBaseFile> getLatestBaseFiles(String partitionStr) {
try {
- readLock.lock();
String partitionPath = formatPartitionKey(partitionStr);
ensurePartitionLoadedCorrectly(partitionPath);
+ readLock.lock();
Review Comment:
I've done this and one thing I was considering is to move the read locks
closer to the actual access so we can minimize the time holding the lock and
reduce the repeated code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
