cshuo commented on code in PR #12967:
URL: https://github.com/apache/hudi/pull/12967#discussion_r2006723562
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -2362,6 +2362,48 @@ void testReadWithParquetPredicatePushDown() {
+ "+I[id8, Han, 56, 1970-01-01T00:00:08, par4]]");
}
+ @ParameterizedTest
+ @MethodSource("indexAndPartitioningParams")
+ void testWriteMultipleCommitWithLegacyAndRowDataWrite(String indexType,
boolean hiveStylePartitioning) throws Exception {
+ // create filesystem table named source
+ String createSource = TestConfigurations.getFileSourceDDL("source");
+ streamTableEnv.executeSql(createSource);
+
+ // insert first batch of data with rowdata mode writing disabled
+ String hoodieTableDDL = sql("t1")
+ .option(FlinkOptions.PATH, tempFile.getAbsolutePath())
+ .option(FlinkOptions.TABLE_TYPE, HoodieTableType.MERGE_ON_READ)
+ .option(FlinkOptions.INDEX_TYPE, indexType)
+ .option(FlinkOptions.HIVE_STYLE_PARTITIONING, hiveStylePartitioning)
+ .option(FlinkOptions.INSERT_ROWDATA_MODE_ENABLED, false)
+ .option(HoodieWriteConfig.ALLOW_EMPTY_COMMIT.key(), false)
+ .end();
+ streamTableEnv.executeSql(hoodieTableDDL);
+ String insertInto = "insert into t1 select * from source";
+ execInsertSql(streamTableEnv, insertInto);
+
+ streamTableEnv.executeSql("drop table t1");
+
+ // insert second batch of data with rowdata mode writing enabled
+ hoodieTableDDL = sql("t1")
+ .option(FlinkOptions.PATH, tempFile.getAbsolutePath())
+ .option(FlinkOptions.TABLE_TYPE, HoodieTableType.MERGE_ON_READ)
+ .option(FlinkOptions.INDEX_TYPE, indexType)
+ .option(FlinkOptions.READ_AS_STREAMING, true)
+ .option(FlinkOptions.READ_START_COMMIT,
FlinkOptions.START_COMMIT_EARLIEST)
+ .option(FlinkOptions.HIVE_STYLE_PARTITIONING, hiveStylePartitioning)
+ .option(FlinkOptions.INSERT_ROWDATA_MODE_ENABLED, true)
Review Comment:
test false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
