yihua commented on code in PR #12991:
URL: https://github.com/apache/hudi/pull/12991#discussion_r2004506918
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/common/TestSqlConf.scala:
##########
@@ -82,7 +82,7 @@ class TestSqlConf extends HoodieSparkSqlTestBase with
BeforeAndAfter {
assertResult(true)(Files.exists(Paths.get(s"$tablePath/$partitionVal")))
assertResult(HoodieTableType.MERGE_ON_READ)(new HoodieTableConfig(
HoodieStorageUtils.getStorage(tablePath,
HoodieTestUtils.getDefaultStorageConf),
- new StoragePath(tablePath, HoodieTableMetaClient.METAFOLDER_NAME),
RecordMergeMode.COMMIT_TIME_ORDERING, null, null).getTableType)
Review Comment:
If we intend to read the table config and check the table type, there is no
need to pass in merge configs. Those should be removed and a different
`HoodieTableConfig` should be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
