cshuo commented on code in PR #13027:
URL: https://github.com/apache/hudi/pull/13027#discussion_r2011449334
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestHoodieDataSource.java:
##########
@@ -147,20 +157,17 @@ void
testStreamWriteAndReadFromSpecifiedCommit(HoodieTableType tableType) throws
.option(FlinkOptions.READ_START_COMMIT, firstCommit)
.end();
streamTableEnv.executeSql(hoodieTableDDL);
- List<Row> rows = execSelectSql(streamTableEnv, "select * from t1", 10);
- assertRowsEquals(rows, TestData.DATA_SET_SOURCE_INSERT);
+ execSelectSqlAndCheckResult(streamTableEnv, "select * from t1",
TestData.DATA_SET_SOURCE_INSERT);
Review Comment:
Do you mean keep the function name unchanged, and just do checking logic
inside `execSelectSql`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
