the-other-tim-brown commented on code in PR #12982:
URL: https://github.com/apache/hudi/pull/12982#discussion_r2032233200
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -452,10 +453,10 @@ &&
noSubsequentReplaceCommit(earliestInstant.requestedTime(), partitionPath)) {
*/
private boolean hasPendingFiles(String partitionPath) {
try {
- HoodieTableFileSystemView fsView =
HoodieTableFileSystemView.fileListingBasedFileSystemView(context,
hoodieTable.getMetaClient(), hoodieTable.getActiveTimeline());
StoragePath fullPartitionPath = new
StoragePath(hoodieTable.getMetaClient().getBasePath(), partitionPath);
- fsView.addFilesToView(partitionPath, FSUtils.getAllDataFilesInPartition(
- hoodieTable.getStorage(), fullPartitionPath));
+ List<StoragePathInfo> allDataFilesInPartition =
FSUtils.getAllDataFilesInPartition(
Review Comment:
This is the same code that exists today.
`FSUtils.getAllDataFilesInPartition` uses file listing and not MDT.
I am just using the proper constructor here for when you want to construct a
view from a set of files. This allows us to keep the `addFilesToView` private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
