linliu-code commented on code in PR #13092:
URL: https://github.com/apache/hudi/pull/13092#discussion_r2029534019
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/MergeIntoHoodieTableCommand.scala:
##########
@@ -769,7 +771,7 @@ case class MergeIntoHoodieTableCommand(mergeInto:
MergeIntoTable) extends Hoodie
SqlKeyGenerator.PARTITION_SCHEMA -> partitionSchema.toDDL,
PAYLOAD_CLASS_NAME.key -> classOf[ExpressionPayload].getCanonicalName,
RECORD_MERGE_IMPL_CLASSES.key -> classOf[HoodieAvroRecordMerger].getName,
- HoodieWriteConfig.RECORD_MERGE_MODE.key() ->
RecordMergeMode.CUSTOM.name(),
Review Comment:
This should be a bug since 1. Merge mode cannot be hard-coded; 2. at this
place this table can be a table with version < 8 or >= 8. Therefore, we need to
get the merge mode accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
