satishkotha commented on pull request #2202: URL: https://github.com/apache/hudi/pull/2202#issuecomment-718182030
> @satishkotha left some comments. > > High level, few more questions: > > 1. Seems like a lot of commonality of code with compaction, are we planning on merging them together ? > 2. I see that we are going to allow schedule clustering for file groups that even have log files, in the scheduling process are we checking if a compaction is already scheduled for some file groups for which we cannot schedule clustering ? 1. This PR just includes FileSystemView APIs. I think its better to keep them separate APIs because the functionality is different (updates are allowed for files in compaction for example). When actual scheduling and clustering is implemented, its possible to reuse some of core logic such as ActionExecutors. Let me know if you see better way to organize this and share FileSystemView API as well 2. scheduling logic is not implemented yet. This is just first PR to cover high level FileSystemView APIs. The next PR will include this logic. Let me know if you want me to combine everything into one PR or if you have any other feedback. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
