lokeshj1703 commented on code in PR #13098:
URL: https://github.com/apache/hudi/pull/13098#discussion_r2033842768
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/MetadataConversionUtils.java:
##########
@@ -338,6 +338,15 @@ public static HoodieArchivedMetaEntry
createMetaWrapperForEmptyInstant(HoodieIns
return archivedMetaWrapper;
}
+ private static <T extends HoodieCommitMetadata> Option<T>
getArchivedCommitMetadata(HoodieTableMetaClient metaClient, HoodieInstant
instant, Class<T> clazz) throws IOException {
+ T commitMetadata =
metaClient.getArchivedTimeline().readInstantContent(instant, clazz);
Review Comment:
That was the previous approach. Davis mentioned that we had moved away from
using the byte array deserialization outside of HoodieTimeline class. So using
the new approach here now.
Although I prefer the older approach. Currently the timeline would have to
load all the instants in memory for downgrading.
cc @nsivabalan what is your take here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
