umehrot2 commented on a change in pull request #2160:
URL: https://github.com/apache/hudi/pull/2160#discussion_r513819850
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/util/HiveSchemaUtil.java
##########
@@ -327,20 +284,14 @@ private static String createHiveMap(String keyType,
String valueType) {
/**
* Create an Array Hive schema from equivalent parquet list type.
*/
- private static String createHiveArray(Type elementType, String elementName) {
+ private static String createHiveArrayFromAvro(String schemaName, Schema
elementType) {
StringBuilder array = new StringBuilder();
array.append("ARRAY< ");
- if (elementType.isPrimitive()) {
- array.append(convertField(elementType));
+ if (elementType.getType().equals(Schema.Type.RECORD) &&
(elementType.getFields().size() == 1
+ && !elementType.getName().equals("array") &&
!elementType.getName().endsWith("_tuple"))) {
Review comment:
Wondering if this conditions is really needed ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
