alexr17 commented on code in PR #13103:
URL: https://github.com/apache/hudi/pull/13103#discussion_r2036459867
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockConfig.java:
##########
@@ -28,53 +28,54 @@
import java.util.concurrent.TimeUnit;
import static org.apache.hudi.common.config.HoodieCommonConfig.BASE_PATH;
-import static
org.apache.hudi.client.transaction.lock.ConditionalWriteLockProvider.DEFAULT_TABLE_LOCK_FILE_NAME;
+import static
org.apache.hudi.client.transaction.lock.StorageBasedLockProvider.DEFAULT_TABLE_LOCK_FILE_NAME;
import static
org.apache.hudi.common.table.HoodieTableMetaClient.LOCKS_FOLDER_NAME;
-public class ConditionalWriteLockConfig extends HoodieConfig {
+public class StorageBasedLockConfig extends HoodieConfig {
private static final String SINCE_VERSION_1_0_2 = "1.0.2";
- private static final String CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX =
LockConfiguration.LOCK_PREFIX
- + "conditional_write.";
+ private static final String STORAGE_BASED_LOCK_PROPERTY_PREFIX =
LockConfiguration.LOCK_PREFIX
+ + "storage";
public static final ConfigProperty<String> LOCK_INTERNAL_STORAGE_LOCATION =
ConfigProperty
- .key(CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX + "locks_location")
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "locks_location")
Review Comment:
> should we also have a default value like .locks
Not sure I understand - I think the latest RFC is a bit different than the
original PR I sent. We are no longer writing to a "locks location" we are
writing to .hoodie/.locks/table_lock.json (unless user specifies
`hoodie.write.lock.storage.locks_location`)
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/StorageBasedLockConfig.java:
##########
@@ -28,53 +28,54 @@
import java.util.concurrent.TimeUnit;
import static org.apache.hudi.common.config.HoodieCommonConfig.BASE_PATH;
-import static
org.apache.hudi.client.transaction.lock.ConditionalWriteLockProvider.DEFAULT_TABLE_LOCK_FILE_NAME;
+import static
org.apache.hudi.client.transaction.lock.StorageBasedLockProvider.DEFAULT_TABLE_LOCK_FILE_NAME;
import static
org.apache.hudi.common.table.HoodieTableMetaClient.LOCKS_FOLDER_NAME;
-public class ConditionalWriteLockConfig extends HoodieConfig {
+public class StorageBasedLockConfig extends HoodieConfig {
private static final String SINCE_VERSION_1_0_2 = "1.0.2";
- private static final String CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX =
LockConfiguration.LOCK_PREFIX
- + "conditional_write.";
+ private static final String STORAGE_BASED_LOCK_PROPERTY_PREFIX =
LockConfiguration.LOCK_PREFIX
+ + "storage";
public static final ConfigProperty<String> LOCK_INTERNAL_STORAGE_LOCATION =
ConfigProperty
- .key(CONDITIONAL_WRITE_LOCK_PROPERTY_PREFIX + "locks_location")
+ .key(STORAGE_BASED_LOCK_PROPERTY_PREFIX + "locks_location")
Review Comment:
> should we also have a default value like .locks
Not sure I understand - I think the latest RFC is a bit different than the
original PR I sent. We are no longer writing to a "locks location" we are
writing to .hoodie/.locks/table_lock.json (unless user specifies
`hoodie.write.lock.storage.locks_location`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
