danny0405 commented on code in PR #13138:
URL: https://github.com/apache/hudi/pull/13138#discussion_r2040855154
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadata.java:
##########
@@ -554,14 +548,8 @@ private Map<String,
List<HoodieRecord<HoodieMetadataPayload>>> fetchBaseFileAllR
}
private HoodieRecord<HoodieMetadataPayload> composeRecord(GenericRecord
avroRecord, String partitionName) {
- if (metadataTableConfig.populateMetaFields()) {
- return SpillableMapUtils.convertToHoodieRecordPayload(avroRecord,
- metadataTableConfig.getPayloadClass(),
metadataTableConfig.getPreCombineField(), false);
- }
- return SpillableMapUtils.convertToHoodieRecordPayload(avroRecord,
- metadataTableConfig.getPayloadClass(),
metadataTableConfig.getPreCombineField(),
- Pair.of(metadataTableConfig.getRecordKeyFieldProp(),
metadataTableConfig.getPartitionFieldProp()),
- false, Option.of(partitionName), Option.empty());
+ return new HoodieAvroRecord<>(new
HoodieKey(avroRecord.get(HoodieMetadataPayload.KEY_FIELD_NAME).toString(),
partitionName),
Review Comment:
yeah, the record key is constant `key` now, if would be better to fetch it
from table config in case this could change in future?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
