the-other-tim-brown commented on code in PR #13148:
URL: https://github.com/apache/hudi/pull/13148#discussion_r2048002135
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/HoodieFileGroupReader.java:
##########
@@ -319,9 +319,6 @@ public void close() throws IOException {
if (recordBuffer != null) {
recordBuffer.close();
}
- if (readerContext != null) {
- readerContext.close();
Review Comment:
No, the schema cache does not actually have anything that requires closing.
The cache object is only referenced from the context that creates it. Once that
context is no longer referenced, the cache is eligible for GC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
