the-other-tim-brown commented on code in PR #13157:
URL: https://github.com/apache/hudi/pull/13157#discussion_r2049519640
##########
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestDataGenerator.java:
##########
@@ -952,10 +952,15 @@ public List<HoodieRecord> generateUpdates(String
instantTime, Integer n) throws
*/
public List<HoodieRecord> generateUpdates(String instantTime, Integer n,
String schemaStr) throws IOException {
List<HoodieRecord> updates = new ArrayList<>();
+ Map<Integer, KeyPartition> existingKeys =
existingKeysBySchema.get(schemaStr);
Review Comment:
There are some cases where there are multiple updates for the same key
expected, like when testing deduping within the ingestion. I will revert the
changes here and just use the other method for these FGReader tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
