yihua commented on code in PR #13179:
URL: https://github.com/apache/hudi/pull/13179#discussion_r2051850664
##########
hudi-io/src/test/java/org/apache/hudi/io/hfile/TestHFileReader.java:
##########
@@ -227,11 +351,15 @@ static Stream<Arguments>
testArgsReadHFilePointAndPrefixLookup() {
Arguments.of(
"/hfile/hudi_1_0_hbase_2_4_9_64KB_NONE_5000.hfile",
5000,
+ KEY_CREATOR,
Arrays.asList(
// before first key
- new KeyLookUpInfo("", SEEK_TO_BEFORE_FIRST_KEY, "", ""),
- new KeyLookUpInfo("a", SEEK_TO_BEFORE_FIRST_KEY, "", ""),
- new KeyLookUpInfo("hudi-key-0000000",
SEEK_TO_BEFORE_FIRST_KEY, "", ""),
+ // before first key
+ new KeyLookUpInfo("", SEEK_TO_BEFORE_FILE_FIRST_KEY,
"hudi-key-000000000", "hudi-value-000000000"),
+ new KeyLookUpInfo("as", SEEK_TO_BEFORE_FILE_FIRST_KEY,
"hudi-key-000000000", "hudi-value-000000000"),
+ // backward seekTo before first key is allowed and safe
Review Comment:
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
