cshuo commented on code in PR #13078:
URL: https://github.com/apache/hudi/pull/13078#discussion_r2052023753
##########
hudi-flink-datasource/hudi-flink/src/test/java/org/apache/hudi/table/ITTestSchemaEvolution.java:
##########
@@ -232,11 +242,12 @@ private void changeTableSchema(TableOptions tableOptions,
boolean shouldCompactB
}
Schema intType =
SchemaBuilder.unionOf().nullType().and().intType().endUnion();
+ Schema longType =
SchemaBuilder.unionOf().nullType().and().longType().endUnion();
Schema doubleType =
SchemaBuilder.unionOf().nullType().and().doubleType().endUnion();
Schema stringType =
SchemaBuilder.unionOf().nullType().and().stringType().endUnion();
Schema structType =
SchemaBuilder.builder().record("new_row_col").fields()
- .name("f0").type("long").noDefault()
- .name("f1").type("string").noDefault().endRecord();
+ .name("f0").type(longType).noDefault()
+ .name("f1").type(stringType).noDefault().endRecord();
Review Comment:
I believe so. The nullability of column fields in `new_row_col` here
(`changeTableSchema`) is not consistent with that in `writeTableWithSchema2`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
