TheR1sing3un commented on code in PR #13189:
URL: https://github.com/apache/hudi/pull/13189#discussion_r2052214647
##########
hudi-common/src/main/java/org/apache/hudi/common/util/hash/BucketIndexUtil.java:
##########
@@ -37,9 +38,12 @@ public class BucketIndexUtil {
*/
public static Functions.Function3<Integer, String, Integer, Integer>
getPartitionIndexFunc(int parallelism) {
return (bucketNum, partition, curBucket) -> {
Review Comment:
> Maybe we can change `Functions.Function3<Integer, String, Integer,
Integer>` to `Functions.Function3<Long, String, Integer, Integer>`
Anyway, bucket-num is expressed using the int type in all code paths. I
think this change is not necessary. After all, we just want to avoid overflow
during the calculation process. The input parameters and the output partition
id itself all need to be of int type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
