yihua commented on code in PR #13167:
URL: https://github.com/apache/hudi/pull/13167#discussion_r2052651783
##########
hudi-common/src/main/java/org/apache/hudi/common/util/ConfigUtils.java:
##########
@@ -92,8 +92,8 @@ public static String getOrderingField(Properties properties) {
/**
* Get payload class.
*/
- public static String getPayloadClass(Properties properties) {
- return HoodieRecordPayload.getPayloadClassName(new
HoodieConfig(properties));
+ public static String getPayloadClass(Properties props) {
+ return HoodieRecordPayload.getPayloadClassName(props);
Review Comment:
It's still good to revisit them and avoid this from happening in the future.
We have landed #13174 and #13173 to address the remaining invocations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
