yihua commented on code in PR #13171:
URL: https://github.com/apache/hudi/pull/13171#discussion_r2053079209
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -91,10 +125,23 @@ public GenericRecord convertToAvroRecord(IndexedRecord
record, Schema schema) {
@Override
public Option<HoodieRecordMerger> getRecordMerger(RecordMergeMode mergeMode,
String mergeStrategyId, String mergeImplClasses) {
- if (mergeMode == RecordMergeMode.CUSTOM) {
- return customMerger;
+ switch (mergeMode) {
+ case EVENT_TIME_ORDERING:
+ return Option.of(new HoodiePreCombineAvroRecordMerger());
Review Comment:
Should a new merger `EventTimeAvroRecordMerger` be created in this case?
`HoodiePreCombineAvroRecordMerger` is only used for dedup and does not handle
deletes.
##########
hudi-common/src/main/java/org/apache/hudi/avro/HoodieAvroReaderContext.java:
##########
@@ -50,18 +59,43 @@
import java.util.stream.Collectors;
import java.util.stream.IntStream;
-import static
org.apache.hudi.common.testutils.reader.HoodieFileSliceTestUtils.ROW_KEY;
+import static
org.apache.hudi.common.config.HoodieReaderConfig.RECORD_MERGE_IMPL_CLASSES_WRITE_CONFIG_KEY;
+import static
org.apache.hudi.common.model.HoodieRecord.RECORD_KEY_METADATA_FIELD;
+import static org.apache.hudi.common.table.HoodieTableConfig.PARTITION_FIELDS;
+import static org.apache.hudi.common.table.HoodieTableConfig.RECORDKEY_FIELDS;
+import static org.apache.hudi.common.util.ValidationUtils.checkState;
-public class HoodieTestReaderContext extends
HoodieReaderContext<IndexedRecord> {
- private Option<HoodieRecordMerger> customMerger;
- private Option<String> payloadClass;
+public class HoodieAvroReaderContext extends
HoodieReaderContext<IndexedRecord> {
Review Comment:
Javadocs on where this is supposed be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
