geserdugarov commented on code in PR #12630:
URL: https://github.com/apache/hudi/pull/12630#discussion_r2053674804
##########
.github/workflows/bot.yml:
##########
@@ -348,7 +348,7 @@ jobs:
SPARK_PROFILE: ${{ matrix.sparkProfile }}
SPARK_MODULES: ${{ matrix.sparkModules }}
run:
- mvn test -Punit-tests -Pjava17 -D"$SCALA_PROFILE" -D"$SPARK_PROFILE"
-DwildcardSuites=skipScalaTests $JAVA_UT_FILTER1 -DfailIfNoTests=false -pl
"hudi-common,$SPARK_COMMON_MODULES,$SPARK_MODULES" $MVN_ARGS
Review Comment:
If we decide to switch to automatic `java17` detection, then here we check
that these detection actually happened. Otherwise, if `java17` profile hasn't
applied automatically, then we should get errors related to missed set of JVM
parameters like `--add-opens=java.base/java.lang=ALL-UNNAMED ...`. Explicit set
of JDK version will hide these issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
