voonhous commented on code in PR #13204:
URL: https://github.com/apache/hudi/pull/13204#discussion_r2053842281
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieCommitMetadata.java:
##########
@@ -54,6 +54,7 @@
*
org.apache.hudi.common.table.timeline.versioning.v2.CommitMetadataSerDeV2#deserialize
method.
* ***************************
*/
+@Deprecated // we should only rely on their avro counterpart completely.
Review Comment:
Nit: Maybe we can provide a more descriptive javadoc?
For example:
```java
/**
* Represents commit metadata.
*
* @deprecated As of Hudi version [version number, e.g., 0.12.0] or [Date,
e.g., 2024-01-15].
* Please use the standard Avro-generated model
* {@link org.apache.hudi.avro.model.HoodieCommitMetadata} instead.
* This class may be removed in a future release.
*/
```
##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieReplaceCommitMetadata.java:
##########
@@ -39,6 +39,7 @@
*
org.apache.hudi.common.table.timeline.versioning.v2.CommitMetadataSerDeV2#deserialize
method.
* ***************************
*/
+@Deprecated // we should only rely on their avro counterpart completely.
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
