vinothchandar commented on a change in pull request #2200:
URL: https://github.com/apache/hudi/pull/2200#discussion_r516256499
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/keygen/ComplexKeyGenerator.java
##########
@@ -18,38 +17,38 @@
package org.apache.hudi.keygen;
-import org.apache.hudi.DataSourceWriteOptions;
-import org.apache.hudi.common.config.TypedProperties;
-
import org.apache.avro.generic.GenericRecord;
+import org.apache.hudi.common.config.TypedProperties;
+import org.apache.hudi.keygen.constant.KeyGeneratorOptions;
+import org.apache.spark.sql.Row;
import java.util.Arrays;
import java.util.stream.Collectors;
-import org.apache.spark.sql.Row;
/**
* Complex key generator, which takes names of fields to be used for recordKey
and partitionPath as configs.
*/
public class ComplexKeyGenerator extends BuiltinKeyGenerator {
- public static final String DEFAULT_RECORD_KEY_SEPARATOR = ":";
+ private CommonComplexKeyGenerator commonComplexKeyGenerator;
public ComplexKeyGenerator(TypedProperties props) {
super(props);
- this.recordKeyFields =
Arrays.stream(props.getString(DataSourceWriteOptions.RECORDKEY_FIELD_OPT_KEY())
+ this.recordKeyFields =
Arrays.stream(props.getString(KeyGeneratorOptions.RECORDKEY_FIELD_OPT_KEY)
Review comment:
ah ok. no problem. this makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
