bvaradar commented on a change in pull request #2192: URL: https://github.com/apache/hudi/pull/2192#discussion_r516757551
########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/schema/SparkAvroPostProcessor.java ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.utilities.schema; + +import org.apache.hudi.AvroConversionUtils; +import org.apache.hudi.common.config.TypedProperties; + +import org.apache.avro.Schema; +import org.apache.spark.api.java.JavaSparkContext; + +public class SparkAvroPostProcessor extends SchemaPostProcessor { Review comment: Can you reference the jira number as part of this class Javadoc so that developers would know why this class exist ? ########## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestSchemaPostProcessor.java ########## @@ -45,14 +50,32 @@ public void testPostProcessor() throws IOException { SchemaProvider provider = UtilHelpers.wrapSchemaProviderWithPostProcessor( UtilHelpers.createSchemaProvider(DummySchemaProvider.class.getName(), properties, jsc), - properties, jsc); + properties, jsc,null); Schema schema = provider.getSourceSchema(); assertEquals(schema.getType(), Type.RECORD); assertEquals(schema.getName(), "test"); assertNotNull(schema.getField("testString")); } + @Test + public void testSparkAvro() throws IOException { + properties.put(Config.SCHEMA_POST_PROCESSOR_PROP, SparkAvroPostProcessor.class.getName()); + List<String> transformerClassNames = new ArrayList<>(); + transformerClassNames.add(FlatteningTransformer.class.getName()); + + SchemaProvider provider = + UtilHelpers.wrapSchemaProviderWithPostProcessor( + UtilHelpers.createSchemaProvider(SparkAvroSchemaProvider.class.getName(), properties, jsc), + properties, jsc, transformerClassNames); + + Schema schema = provider.getSourceSchema(); Review comment: Can you add a check that post processed schema is different from original schema. ########## File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java ########## @@ -413,14 +414,19 @@ public static SchemaProviderWithPostProcessor wrapSchemaProviderWithPostProcesso if (provider instanceof SchemaProviderWithPostProcessor) { return (SchemaProviderWithPostProcessor)provider; } + String schemaPostProcessorClass = cfg.getString(Config.SCHEMA_POST_PROCESSOR_PROP, null); + if (transformerClassNames != null && !transformerClassNames.isEmpty() && StringUtils.isNullOrEmpty(schemaPostProcessorClass)) { Review comment: I think it is safer to add a configuration (enabled by default) if users do not need this feature. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
