vinothchandar commented on a change in pull request #2202: URL: https://github.com/apache/hudi/pull/2202#discussion_r516826336
########## File path: hudi-common/src/main/avro/HoodieClusteringGroup.avsc ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +{ + "namespace":"org.apache.hudi.avro.model", + "type":"record", + "name":"HoodieClusteringGroup", + "type":"record", + "fields":[ + { + /* Group of files that needs to merged. All the slices in a group will belong to same partition initially. Review comment: I wonder if we should start out with the assumption of having all files in a given partition. Does this simplify anything in the design now? I would love to implement this generically right away, otherwise we will spend cycles thinking about migrations, eetc etc down the line. ########## File path: hudi-common/src/main/avro/HoodieSliceInfo.avsc ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +{ + "namespace":"org.apache.hudi.avro.model", + "type":"record", + "name":"HoodieSliceInfo", + "fields":[ + { + "name":"dataFilePath", + "type":["null","string"], + "default": null + }, + { + "name":"deltaFilePaths", + "type":["null", { + "type":"array", + "items":"string" + }], + "default": null + }, + { + "name":"fileId", + "type":["null","string"] + }, + { + "name":"partitionPath", + "type":["null","string"], + "default": null + }, + { + "name":"bootstrapFilePath", Review comment: this can be fetched from the bootstrap index as well right? its immutable anyway? ########## File path: hudi-common/src/main/avro/HoodieSliceInfo.avsc ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +{ + "namespace":"org.apache.hudi.avro.model", + "type":"record", + "name":"HoodieSliceInfo", Review comment: lets ensure this also contains a version field? in fact, any of these new avsc should have a version at the start preferably, so we can evolve. ########## File path: hudi-common/src/main/avro/HoodieClusteringGroup.avsc ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +{ + "namespace":"org.apache.hudi.avro.model", + "type":"record", + "name":"HoodieClusteringGroup", + "type":"record", + "fields":[ + { + /* Group of files that needs to merged. All the slices in a group will belong to same partition initially. Review comment: or you are just suggesting that the clustreing strategy currently only does it within partitions? (totally reasonable approach!) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
