danny0405 commented on code in PR #12490:
URL: https://github.com/apache/hudi/pull/12490#discussion_r2059428715
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkFileGroupReaderBasedMergeHandle.java:
##########
@@ -95,7 +95,11 @@ public void write() {
storage.newInstance(hoodieTable.getMetaClient().getBasePath(),
readerContext.getStorageConfiguration()),
hoodieTable.getMetaClient().getBasePath().toString(), instantTime,
fileSlice,
writeSchemaWithMetaFields, writeSchemaWithMetaFields,
internalSchemaOption,
- hoodieTable.getMetaClient(), props, 0, Long.MAX_VALUE, usePosition,
false)) {
+ hoodieTable.getMetaClient(), props, 0,
+ // The compaction plan does not contain the length of the bootstrap
data or skeleton
Review Comment:
avoid to use hardcode `-1` to indicate the invalid length? Maybe we move it
as a public static constant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
