cshuo commented on code in PR #13225: URL: https://github.com/apache/hudi/pull/13225#discussion_r2062569206
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/BufferedRecord.java: ########## @@ -0,0 +1,110 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hudi.common.table.read; + +import org.apache.hudi.common.engine.HoodieReaderContext; +import org.apache.hudi.common.model.DeleteRecord; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.exception.HoodieException; + +import org.apache.avro.Schema; + +import java.io.IOException; +import java.io.Serializable; +import java.util.Properties; + +import static org.apache.hudi.common.model.HoodieRecord.DEFAULT_ORDERING_VALUE; + +/** + * Buffered Record used by file group reader. + * + * @param <T> The type of the engine specific row. + */ +public class BufferedRecord<T> implements Serializable { Review Comment: `BufferedRecord` is introduced for merging and caching purpose in file group reader: 1) there exists different apis between `BufferedRecord` and `HoodieRecord`, these changes are specific for fg reader, and may not general enough to `HoodieRecord`, e.g., `getSchemaId`, `toBinary`. 2) `BufferedRecord` will be cached and serialized into `ExternalSpillableMap`, and it's known that the perf bottleneck of compaction lies in the spilling of `ExternalSpillableMap`, so we tries to make the caching record simple and cleaner enough to save more space and reduce spilling. We've run a microbenchmark for the PR, and 50%+ memory for `ExternalSpillableMap` in FG reader are saved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
