yihua commented on code in PR #13223:
URL: https://github.com/apache/hudi/pull/13223#discussion_r2065662115
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/common/TestHoodieInternalRowUtils.scala:
##########
@@ -192,7 +192,7 @@ class TestHoodieInternalRowUtils extends FunSuite with
Matchers with BeforeAndAf
val newRowExpected =
AvroConversionUtils.createAvroToInternalRowConverter(newAvroSchema,
newStructTypeSchema)
.apply(newRecord).get
- val rowWriter =
HoodieInternalRowUtils.genUnsafeRowWriter(structTypeSchema,
newStructTypeSchema, new HashMap[String, String])
+ val rowWriter =
HoodieInternalRowUtils.genUnsafeRowWriter(structTypeSchema,
newStructTypeSchema, JCollections.emptyMap(), JCollections.emptyMap())
Review Comment:
nit: unit tests on `genUnsafeRowWriter` with non-empty update values could
be added too.
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/table/format/FlinkRowDataReaderContext.java:
##########
@@ -195,7 +195,9 @@ public ClosableIterator<RowData> mergeBootstrapReaders(
ClosableIterator<RowData> skeletonFileIterator,
Schema skeletonRequiredSchema,
ClosableIterator<RowData> dataFileIterator,
- Schema dataRequiredSchema) {
+ Schema dataRequiredSchema,
+ Option<String[]> partitionFields,
Review Comment:
Should the iterator be fixed too to consider the partition values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
