danny0405 commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2067698914
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java:
##########
@@ -46,7 +46,7 @@
* allow in-place updates due to its memory layout)</li>
* </ul>
*/
-public class HoodieInternalRow extends InternalRow {
+public abstract class HoodieInternalRow extends InternalRow {
Review Comment:
It looks like there is no need to make this class as `abstract` since the
`#copy` method is the same for Spark4 and we can still subclass it seperately
for Variable data type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
