the-other-tim-brown commented on code in PR #13242: URL: https://github.com/apache/hudi/pull/13242#discussion_r2070719760
########## hudi-common/src/main/java/org/apache/hudi/common/table/read/EngineBasedMerger.java: ########## @@ -0,0 +1,189 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.hudi.common.table.read; + +import org.apache.hudi.avro.AvroSchemaCache; +import org.apache.hudi.common.config.RecordMergeMode; +import org.apache.hudi.common.config.TypedProperties; +import org.apache.hudi.common.engine.HoodieReaderContext; +import org.apache.hudi.common.model.DefaultHoodieRecordPayload; +import org.apache.hudi.common.model.HoodieAvroRecord; +import org.apache.hudi.common.model.HoodieKey; +import org.apache.hudi.common.model.HoodieRecord; +import org.apache.hudi.common.model.HoodieRecordMerger; +import org.apache.hudi.common.model.OverwriteWithLatestAvroPayload; +import org.apache.hudi.common.table.HoodieTableConfig; +import org.apache.hudi.common.util.HoodieRecordUtils; +import org.apache.hudi.common.util.Option; +import org.apache.hudi.common.util.ValidationUtils; +import org.apache.hudi.common.util.collection.Pair; + +import org.apache.avro.Schema; +import org.apache.avro.generic.GenericRecord; +import org.apache.avro.generic.IndexedRecord; + +import java.io.IOException; +import java.util.Objects; + +import static org.apache.hudi.common.model.HoodieRecordMerger.PAYLOAD_BASED_MERGE_STRATEGY_UUID; + +public class EngineBasedMerger<T> { + private final HoodieReaderContext<T> readerContext; + private final RecordMergeMode recordMergeMode; + private final Option<HoodieRecordMerger> recordMerger; + private final Option<String> payloadClass; + private final Schema readerSchema; + private final TypedProperties props; + + public EngineBasedMerger(HoodieReaderContext<T> readerContext, RecordMergeMode recordMergeMode, HoodieTableConfig tableConfig, TypedProperties props) { + this.readerContext = readerContext; + this.readerSchema = AvroSchemaCache.intern(readerContext.getSchemaHandler().getRequiredSchema()); + this.recordMergeMode = recordMergeMode; + this.recordMerger = readerContext.getRecordMerger(); + if (recordMerger.isPresent() && recordMerger.get().getMergingStrategy().equals(PAYLOAD_BASED_MERGE_STRATEGY_UUID)) { + this.payloadClass = Option.of(tableConfig.getPayloadClass()); + } else { + this.payloadClass = Option.empty(); + } + this.props = props; + } + + BufferedRecord<T> merge(Option<BufferedRecord<T>> olderOption, Review Comment: There are 2 places in the record buffer that do merges so there are some changes as a result. Mainly the output is always a BufferedRecord and now the caller must handle the deletes instead of an empty option. There was also a step for converting the output of a RecordMerger step to use the reader schema. This is now outside of the merging logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
