danny0405 commented on code in PR #13240:
URL: https://github.com/apache/hudi/pull/13240#discussion_r2070979223
##########
hudi-client/hudi-flink-client/src/main/java/org/apache/hudi/table/action/commit/BaseFlinkCommitActionExecutor.java:
##########
@@ -62,46 +62,54 @@
* we should avoid that in streaming system.
*/
public abstract class BaseFlinkCommitActionExecutor<T> extends
- BaseCommitActionExecutor<T, List<HoodieRecord<T>>, List<HoodieKey>,
List<WriteStatus>, HoodieWriteMetadata> {
+ BaseCommitActionExecutor<T, Iterator<HoodieRecord<T>>, List<HoodieKey>,
List<WriteStatus>, HoodieWriteMetadata> {
private static final Logger LOG =
LoggerFactory.getLogger(BaseFlinkCommitActionExecutor.class);
protected HoodieWriteHandle<?, ?, ?, ?> writeHandle;
+ protected final BucketInfo bucketInfo;
+
+ public BaseFlinkCommitActionExecutor(HoodieEngineContext context,
+ HoodieWriteHandle<?, ?, ?, ?>
writeHandle,
+ HoodieWriteConfig config,
+ HoodieTable table,
+ String instantTime,
+ WriteOperationType operationType) {
+ this(context, writeHandle, null, config, table, instantTime,
operationType, Option.empty());
Review Comment:
the `bucketInfo` should be never null?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
