nsivabalan commented on code in PR #13236:
URL: https://github.com/apache/hudi/pull/13236#discussion_r2071174155


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -980,6 +1099,13 @@ private void startCommitWithTime(String instantTime, 
String actionType, HoodieTa
       
metaClient.getActiveTimeline().createNewInstant(metaClient.createNewInstant(HoodieInstant.State.REQUESTED,
 actionType,
           instantTime));
     }
+
+    // Even among supported operations, bulk insert to be precise, row writer 
does not support optimized writes. So, we had to leverage additional argument 
named `skipOptimizedWrites`
+    Option<HoodieTableMetadataWriter> metadataWriterOpt = skipOptimizedWrites 
? Option.empty() :
+        
(config.isStreamingWritesToMetadataEnabled(metaClient.getTableConfig().getTableVersion())
 ? getMetadataWriter(instantTime, metaClient) : Option.empty());

Review Comment:
   Starting commit in metadata table as well 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to