nsivabalan commented on code in PR #13236:
URL: https://github.com/apache/hudi/pull/13236#discussion_r2071291465
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -234,14 +251,30 @@ protected HoodieWriteMetadata<O> logCompact(String
logCompactionInstantTime, boo
}
logCompactionTimer = metrics.getLogCompactionCtx();
WriteMarkersFactory.get(config.getMarkersType(), table,
logCompactionInstantTime);
+ // initialize streaming writer to MDT if enabled
+ Option<HoodieTableMetadataWriter> metadataWriterOpt =
mayBeInitStreamingWriterToMetadataTable(table.getMetaClient(),
logCompactionInstantTime);
HoodieWriteMetadata<T> writeMetadata = table.logCompact(context,
logCompactionInstantTime);
- HoodieWriteMetadata<O> logCompactionMetadata =
convertToOutputMetadata(writeMetadata);
- if (shouldComplete &&
logCompactionMetadata.getCommitMetadata().isPresent()) {
- completeLogCompaction(logCompactionMetadata.getCommitMetadata().get(),
table, logCompactionInstantTime);
+ HoodieWriteMetadata<T> processedWriteMetadata =
mayBeStreamWriteToMetadataTable(writeMetadata, logCompactionInstantTime,
metadataWriterOpt);
+ HoodieWriteMetadata<O> logCompactionMetadata =
convertToOutputMetadata(processedWriteMetadata);
+ if (shouldComplete) {
+ commitLogCompaction(logCompactionInstantTime, logCompactionMetadata,
Option.of(table), metadataWriterOpt);
}
return logCompactionMetadata;
}
+ private Option<HoodieTableMetadataWriter>
mayBeInitStreamingWriterToMetadataTable(HoodieTableMetaClient metaClient,
String instantTime) {
Review Comment:
initialize metadata writer for a table service if enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
