wombatu-kun commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2072358257
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java:
##########
@@ -46,7 +46,7 @@
* allow in-place updates due to its memory layout)</li>
* </ul>
*/
-public class HoodieInternalRow extends InternalRow {
+public abstract class HoodieInternalRow extends InternalRow {
Review Comment:
if we make it non-abstract we'll have to impelment `VariantVal
getVariant(int ordinal)` in `HoodieInternalRow` (in hudi-spark-client), but
VariantVal does not exist in Spark versions earlier than 4.
Anyway, i've tried what you proposed, but build fails with spark3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
