danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2072492884
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/SparkRDDTableServiceClient.java:
##########
@@ -33,18 +35,35 @@
import org.apache.spark.api.java.JavaRDD;
+import java.util.List;
+
public class SparkRDDTableServiceClient<T> extends
BaseHoodieTableServiceClient<HoodieData<HoodieRecord<T>>,
HoodieData<WriteStatus>, JavaRDD<WriteStatus>> {
protected SparkRDDTableServiceClient(HoodieEngineContext context,
HoodieWriteConfig clientConfig,
Option<EmbeddedTimelineService>
timelineService) {
super(context, clientConfig, timelineService);
}
+ @Override
+ protected List<HoodieWriteStat>
triggerWritesAndFetchWriteStats(HoodieWriteMetadata<JavaRDD<WriteStatus>>
writeMetadata) {
+ return writeMetadata.getWriteStatuses().map(writeStatus ->
writeStatus.getStat()).collect();
+ }
+
@Override
protected HoodieWriteMetadata<JavaRDD<WriteStatus>>
convertToOutputMetadata(HoodieWriteMetadata<HoodieData<WriteStatus>>
writeMetadata) {
return
writeMetadata.clone(HoodieJavaRDD.getJavaRDD(writeMetadata.getWriteStatuses()));
}
+ @Override
+ protected void
runPrecommitValidators(HoodieWriteMetadata<JavaRDD<WriteStatus>> writeMetadata,
HoodieTable table, String instantTime) {
Review Comment:
then maybe we should rename this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
