yihua commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2073997079
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/client/model/HoodieInternalRow.java:
##########
@@ -46,7 +46,7 @@
* allow in-place updates due to its memory layout)</li>
* </ul>
*/
-public class HoodieInternalRow extends InternalRow {
+public abstract class HoodieInternalRow extends InternalRow {
Review Comment:
@wombatu-kun let's call out these major changes in the PR description, and
add Javadocs if needed so it's easier to track these. That'll help reviewers
and subsequent Spark version support (at least 4 developers have been involved
in Spark version support PRs so far :) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
