yihua commented on code in PR #12772:
URL: https://github.com/apache/hudi/pull/12772#discussion_r2076268237
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/index/TestIndexSyntax.scala:
##########
@@ -73,7 +73,10 @@ class TestIndexSyntax extends HoodieSparkSqlTestBase {
assertResult(false)(resolvedLogicalPlan.asInstanceOf[CreateIndexCommand].ignoreIfExists)
assertResult(Map("block_size" ->
"1024"))(resolvedLogicalPlan.asInstanceOf[CreateIndexCommand].options)
- logicalPlan = sqlParser.parsePlan(s"create index if not exists
idx_price on $tableName using lucene (price options(order='desc'))
options(block_size=512)")
+ // create index if not exists idx_price on $tableName using lucene
(price options(`order`='desc')) options(block_size=512)
+ // would work
+ // original would fail: create index if not exists idx_price on
$tableName using lucene (price options(order='desc')) options(block_size=512)
Review Comment:
remove comments
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/feature/index/TestIndexSyntax.scala:
##########
@@ -73,7 +73,10 @@ class TestIndexSyntax extends HoodieSparkSqlTestBase {
assertResult(false)(resolvedLogicalPlan.asInstanceOf[CreateIndexCommand].ignoreIfExists)
assertResult(Map("block_size" ->
"1024"))(resolvedLogicalPlan.asInstanceOf[CreateIndexCommand].options)
- logicalPlan = sqlParser.parsePlan(s"create index if not exists
idx_price on $tableName using lucene (price options(order='desc'))
options(block_size=512)")
+ // create index if not exists idx_price on $tableName using lucene
(price options(`order`='desc')) options(block_size=512)
+ // would work
+ // original would fail: create index if not exists idx_price on
$tableName using lucene (price options(order='desc')) options(block_size=512)
+ logicalPlan = sqlParser.parsePlan(s"create index if not exists
idx_price on $tableName using lucene (price options(`order`='desc'))
options(block_size=512)")
Review Comment:
fix indentation.
Is this because of the SQL parser? Could we fix that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
