yihua commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2078571692
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1163,13 +1155,17 @@ protected void
completeLogCompaction(HoodieCommitMetadata metadata, HoodieTable
tableServiceClient.completeLogCompaction(metadata, table,
logCompactionCommitTime);
}
+ public void completeLogCompaction(String compactionInstantTime,
HoodieWriteMetadata<O> compactionWriteMetadata, Option<HoodieTable> tableOpt) {
Review Comment:
This is only used by tests. Could we make this default visibility and
visible to tests only? Also why is this method needed for production code?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1190,7 +1186,7 @@ protected Option<String>
inlineScheduleCompaction(Option<Map<String, String>> ex
* @param logCompactionInstantTime Compaction Instant Time
* @return Collection of Write Status
*/
- protected HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime,
boolean shouldComplete) {
+ public HoodieWriteMetadata<O> logCompact(String logCompactionInstantTime,
boolean shouldComplete) {
Review Comment:
It looks like `#compact` and `#logCompact` are only used by the metadata
table. Now that these are made public they can cause confusion. Could you
file a JIRA ticket revisit whether we should fold the logic into metadata
writer only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
