danny0405 commented on code in PR #13242:
URL: https://github.com/apache/hudi/pull/13242#discussion_r2078761147
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/KeyBasedFileGroupRecordBuffer.java:
##########
@@ -100,17 +102,8 @@ public void processDeleteBlock(HoodieDeleteBlock
deleteBlock) throws IOException
Iterator<DeleteRecord> it =
Arrays.stream(deleteBlock.getRecordsToDelete()).iterator();
while (it.hasNext()) {
DeleteRecord record = it.next();
- processNextDeletedRecord(record, record.getRecordKey());
- }
- }
-
- @Override
- public void processNextDeletedRecord(DeleteRecord deleteRecord, Serializable
recordKey) {
- BufferedRecord<T> existingRecord = records.get(recordKey);
Review Comment:
> There can be deletions inside of data records as well
it's true but the paload data is there while the `DeleteRecord` is not, I
know unifying of code is good but it woud mess up the `BufferedRecord` ->
`HoodieRecord` conversion because the later can only be constructed as empty
hoodie record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
