danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2080672171


##########
hudi-client/hudi-java-client/src/test/java/org/apache/hudi/client/TestJavaHoodieBackedMetadata.java:
##########
@@ -1668,7 +1668,7 @@ private void testTableOperationsImpl(HoodieEngineContext 
engineContext, HoodieWr
         client.scheduleCompactionAtInstant(newCommitTime, Option.empty());
         HoodieWriteMetadata writeMetadata = client.compact(newCommitTime);
         client.commitCompaction(newCommitTime, writeMetadata, Option.empty());
-        metaClient.reloadActiveTimeline().containsInstant(newCommitTime);
+        
metaClient.reloadActiveTimeline().filterCompletedInstants().containsInstant(newCommitTime);

Review Comment:
   sorry I still didn't get why we add this:
   
   ```java
   metaClient.reloadActiveTimeline.containsInstant(newInstant)
   ```
   
   what happens if the `#containsInstant` return false?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to