yihua commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2078728420
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriterTableVersionSix.java:
##########
@@ -291,7 +291,7 @@ String createCleanInstantTime(String instantTime) {
@Override
String createRestoreInstantTime() {
- return createRestoreTimestamp(writeClient.createNewInstantTime(false));
+ return
createRestoreTimestamp(getWriteClient().createNewInstantTime(false));
Review Comment:
Is this fixing a bug?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataWriter.java:
##########
@@ -116,4 +117,6 @@ public interface HoodieTableMetadataWriter extends
Serializable, AutoCloseable {
default void performTableServices(Option<String> inFlightInstantTimestamp) {
performTableServices(inFlightInstantTimestamp, false);
}
+
+ BaseHoodieWriteClient<?, I, ?, O> getWriteClient();
Review Comment:
should this be protected?
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -1759,12 +1763,12 @@ public boolean isInitialized() {
return initialized;
}
- protected BaseHoodieWriteClient<?, I, ?, ?> getWriteClient() {
+ public BaseHoodieWriteClient<?, I, ?, O> getWriteClient() {
Review Comment:
Is this used outside the metadata writer class? It looks unsafe to expose
this as public.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
