danny0405 commented on code in PR #13229:
URL: https://github.com/apache/hudi/pull/13229#discussion_r2084489538


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/action/rollback/TestCopyOnWriteRollbackActionExecutor.java:
##########
@@ -283,61 +283,66 @@ public void testRollbackScale() throws Exception {
 
   private void performRollbackAndValidate(boolean isUsingMarkers, 
HoodieWriteConfig cfg, HoodieTable table,
                                           List<FileSlice> 
firstPartitionCommit2FileSlices,
-                                          List<FileSlice> 
secondPartitionCommit2FileSlices) throws IOException {
-    //2. rollback
-    HoodieInstant commitInstant;
-    if (isUsingMarkers) {
-      commitInstant = 
table.getActiveTimeline().getCommitAndReplaceTimeline().filterInflights().lastInstant().get();
-    } else {
-      commitInstant = table.getCompletedCommitTimeline().lastInstant().get();
-    }
+                                          List<FileSlice> 
secondPartitionCommit2FileSlices) throws IOException, InterruptedException {
+    // Create a client to start timeline service needed by the rollback action 
executor
+    try (SparkRDDWriteClient client = getHoodieWriteClient(cfg)) {
+      // Sleep for timeline service to start listening on the port

Review Comment:
   why it is related with auto commit?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to